Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance encoding algorithm and improve naming convention #594

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Enhance encoding algorithm and improve naming convention #594

merged 3 commits into from
Dec 30, 2024

Conversation

Ja7ad
Copy link
Collaborator

@Ja7ad Ja7ad commented Dec 25, 2024

What does this PR do?

  • Fix return buffers to the pool after use
  • Add encoding and decoding benchmark
  • Improve naming convention

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Ja7ad Ja7ad requested a review from curquiza December 25, 2024 08:07
@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.22%. Comparing base (6f83ef3) to head (12e4658).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   86.21%   86.22%           
=======================================
  Files          14       14           
  Lines        2843     2845    +2     
=======================================
+ Hits         2451     2453    +2     
  Misses        282      282           
  Partials      110      110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

curquiza
curquiza reviewed Dec 30, 2024
View reviewed changes
meilisearch_interface.go
Comment on lines -13 to -17
GetServiceReader() ServiceReader
GetTaskManager() TaskManager
GetTaskReader() TaskReader
GetKeyManager() KeyManager
GetKeyReader() KeyReader
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change breaking for users?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

@curquiza curquiza added the enhancement New feature or request label Dec 30, 2024
curquiza
curquiza approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfecto

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Dec 30, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit c167439 into meilisearch:main Dec 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ja7ad @curquiza